[Bug] Fixing up other misc. RNG calls #4870
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blocker #4766
What are the changes the user will see?
More predictable RNG behavior.
Why am I making these changes?
Needs to be done.
Resolves #4527
What are the changes from a developer perspective?
Changes RNG to be based on the current battle's seed if it should be so. Otherwise, the Phaser.Math.RND class function should be replaced with a function within Utils and match the game's conventions.
List of Changes to RNG:
How to test the changes?
Rolls should be based on the current battle and affected by previous actions within that battle.
Checklist
betaas my base branchnpm run test)